-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STAR GenomeGenerate doesn't happen with --additional_fasta unless --star_index is false #556
Comments
Hi @olgabot !! Apologies for the ridiculously late response. The logic here looks ok no? If the user provides a STAR index you would have to assume they want to use that particula STAR index? For example, if you don't provide a STAR index and it is generated using |
Ping @olgabot ! Maybe I misunderstood something here? I will give you the chance to tell me I have before I close this! |
@drpatelh I think I agree with @olgabot on this one. Although your reasoning is correct, I think a lot of users (myself included) are going to black-box these low-level processing steps. I initially ran into the same error as @olgabot using a local hardcopy of my genome of interest, and was confused when I couldn't find counts for my transgenes in the final count matrix. I agree that a rebuild probably shouldn't be the default action, but a strong warning is probably merited here. Works beautifully with |
Ok. Warning it is 👍🏽 Will add it to the next release. |
Warning below added in #681 |
Check Documentation
I have checked the following places for your error:
Description of the bug
If
--additional_fasta
is provided, a new genome is not generated unless--star_index
is set to false.`--additional_fasta`, with `--star_index` but no new genome generated
This job fails because the
--star_index
was made with an older version of STAR and is incompatible wtih the current version of STAR.`--additional_fasta` with `--star_index` false --> new genome generated
Steps to reproduce
Steps to reproduce the behaviour:
`nextflow run nf-core/rnaseq -profile test,docker` --> no new genome generated
Produces:
`nextflow run nf-core/rnaseq -profile test,docker --star_index false` --> new genome generated
No error message, see logs above
Expected behaviour
I expected
--additional_fasta
to trigger a new genome build.Log files
Have you provided the following extra information/files:
.nextflow.log
fileSystem
Nextflow Installation
Container engine
The text was updated successfully, but these errors were encountered: