Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1023

Merged
merged 4 commits into from
May 11, 2023
Merged

Update README.md #1023

merged 4 commits into from
May 11, 2023

Conversation

Ghepardo
Copy link
Contributor

@Ghepardo Ghepardo commented May 11, 2023

Corrected spelling of name "Edmund Miller".

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

drpatelh and others added 4 commits March 30, 2023 14:26
Dev -> Master for 3.11 release
Dev -> Master for v3.11.1 release
Dev -> Master for 3.11.2 release
Corrected spelling of name "Edmund Miller".
@github-actions
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @Ghepardo,

It looks like this pull-request is has been made against the Ghepardo/rnaseq master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the Ghepardo/rnaseq dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@Ghepardo Ghepardo changed the base branch from master to dev May 11, 2023 10:48
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ghepardo ! @emiller88 will be pleased!!

@drpatelh drpatelh merged commit b705ef6 into nf-core:dev May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants