Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PROFILES: test -> test_cache + restore test #1026

Merged
merged 5 commits into from
May 25, 2023
Merged

PROFILES: test -> test_cache + restore test #1026

merged 5 commits into from
May 25, 2023

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented May 15, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit cfe179a

+| ✅ 150 tests passed       |+
#| ❔   5 tests were ignored |#
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: lib/NfcoreSchema.groovy
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/rnaseq/rnaseq/.github/workflows/awstest.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-05-23 11:39:02

@maxulysse
Copy link
Member Author

Logic behind this PR is to keep profile test as a works everywhere/resolve everywhere profile.
The underlying logic with params.test_data_base, makes it complicated to resolve config properly and can hide params.
I'd then recommend to have 2 profiles (which would actually be the same once all params and path are resolved), but one that can work as is, without any resolving issues (historical test profile), and the other from which we can change provenance of files (test_cache profile).

drpatelh
drpatelh reviewed May 15, 2023
View reviewed changes
conf/test_cache.config Outdated Show resolved Hide resolved
drpatelh
drpatelh reviewed May 23, 2023
View reviewed changes
conf/test.config Outdated Show resolved Hide resolved
@maxulysse @drpatelh
Update conf/test.config
cfe179a 
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
drpatelh
drpatelh approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maxulysse ! I'll make the remaining changes in a follow up PR.

conf/test.config Outdated Show resolved Hide resolved
conf/test_cache.config
@@ -0,0 +1,50 @@
/*
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Nextflow config file for running minimal tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Nextflow config file for running minimal tests
Nextflow config file for running minimal tests using cached / offline test data

@drpatelh drpatelh merged commit 9472aaa into nf-core:dev May 25, 2023
@maxulysse maxulysse deleted the profile_test_data_base branch May 25, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drpatelh drpatelh drpatelh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @drpatelh