Dev -> Master for 3.13.0 release #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ination with the STAR-RSEM route.
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Display a warning when '--star_extra_alignment_args' are used with RSEM
Update public_aws_ecr.config
Remove public_aws_ecr profile
Important! Template update for nf-core/tools v2.9
Update credits for subway map
Use nf-validation plugin for parameter and samplesheet validation
maxulysse
reviewed
Nov 16, 2023
maxulysse
reviewed
Nov 16, 2023
maxulysse
reviewed
Nov 16, 2023
conf/test.config
Outdated
There was a problem hiding this comment.
ok, so what happened with the rnaseq -> 7f1614baeb0ddf66e60be78c3d9fa55440465ac8 bit?
We should not change files that already there if it break tests, but add new ones and change the link in this PR
There was a problem hiding this comment.
Because stuff like this happens (you literally approved a test file change I PR'd the other day :-D ), and using a commit makes sure it won't break anything if it does :-). I don't think we should be relying on the good sense of human beings for this sort of thing.
There was a problem hiding this comment.
yeah, I know, but that was in dev, now it's for a release, the stakes are higher
maxulysse
reviewed
Nov 16, 2023
maxulysse
reviewed
Nov 16, 2023
maxulysse
reviewed
Nov 16, 2023
maxulysse
reviewed
Nov 16, 2023
Maxime feedback
FIX: Subway map
final updates on subway map
maxulysse
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.