Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nf-core download test #1441

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Fix nf-core download test #1441

merged 3 commits into from
Oct 24, 2024

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @maxulysse,

It looks like this pull-request is has been made against the maxulysse/nf-core_rnaseq master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the maxulysse/nf-core_rnaseq dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@maxulysse
Copy link
Member Author

I'm seeing this in the download GHA:

Pulling Singularity image https://community-cr-prod.seqera.io/docker/registry/v2/blobs/sha256/63/6397750e9730a3fbcc5b4c43f14bd141c64c723fd7dad80e47921a68a7c3cd21/data [cache /home/runner/work/rnaseq/rnaseq/./singularity_container_images/community-cr-prod.seqera.io-docker-registry-v2-blobs-sha256-63-6397750e9730a3fbcc5b4c43f14bd141c64c723fd7dad80e47921a68a7c3cd21-data.img]

and I'm wondering where this is coming from since I don't have any container pointing to community-cr-prod.seqera.io anywhere

@maxulysse maxulysse changed the base branch from master to dev October 24, 2024 08:14
@maxulysse
Copy link
Member Author

it works: https://github.com/nf-core/rnaseq/actions/runs/11496567950/job/31998439226

pinin4fjords
pinin4fjords approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until we figure out the proper tools fix I think this is an OK workaround

@maxulysse maxulysse merged commit 8cddc95 into nf-core:dev Oct 24, 2024
43 checks passed
@pinin4fjords
Copy link
Member

Proper fix is here: nf-core/tools#3244

@pinin4fjords
Copy link
Member

(so we can probably revert this next release)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinin4fjords pinin4fjords pinin4fjords approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @pinin4fjords