Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pubmed url schema. #538

Merged
merged 1 commit into from
Dec 14, 2020
Merged

update pubmed url schema. #538

merged 1 commit into from
Dec 14, 2020

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Dec 14, 2020

Minor thing, because pubmed resolves the old url into the new ones on their end, but good to fix anyway.

PR checklist

  • PR is to dev rather than master
  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated

@drpatelh
Copy link
Member

Thanks! I used citedown.py to fetch and render the Markdown into something that is more malleable to insert into that document. This tool generates the URLs in the old format.

@drpatelh
Copy link
Member

I guess it doesn't matter as much now because this process is still a manual one, and it works either way so I am not that fussed. Let's get your contribution into the codebase though!

Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Fairly minor change where tests will be re-run on the PR from Dev -> Master again anyway. Thanks @mashehu !

@drpatelh drpatelh merged commit cd886e4 into nf-core:dev Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants