Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spring-icon to subway-map #1558

Closed
asp8200 opened this issue Jun 10, 2024 · 0 comments
Closed

Add spring-icon to subway-map #1558

asp8200 opened this issue Jun 10, 2024 · 0 comments
Assignees
@maxulysse
Labels
docs good first issue Good for newcomers
Milestone
3.5

Comments

@asp8200
Copy link
Contributor

asp8200 commented Jun 10, 2024

Description of feature

After this spring-PR has been merged, we also need to add a spring-icon to the subway-map.

image
@asp8200 asp8200 added the enhancement New feature or request label Jun 10, 2024
@asp8200 asp8200 mentioned this issue Jun 10, 2024
Merged
11 tasks
@FriederikeHanssen FriederikeHanssen added docs and removed enhancement New feature or request labels Jul 8, 2024
@FriederikeHanssen FriederikeHanssen added this to the 3.5 milestone Jul 8, 2024
@FriederikeHanssen FriederikeHanssen removed this from the 3.5 milestone Aug 19, 2024
@FriederikeHanssen FriederikeHanssen added this to the 3.5 milestone Oct 26, 2024
@FriederikeHanssen FriederikeHanssen added the good first issue Good for newcomers label Oct 26, 2024
@FriederikeHanssen FriederikeHanssen mentioned this issue Nov 15, 2024
Merged
11 tasks
maxulysse pushed a commit that referenced this issue Nov 18, 2024
@FriederikeHanssen
Add spring and ubam files to overview pictures (#1734)
22c7315 
Closes #1558 
<!--
# nf-core/sarek pull request

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not
relevant).
These are the most common things requested on pull requests (PRs).

Remember that PRs should be made against the dev branch, unless you're
preparing a pipeline release.

Learn more about contributing:
[CONTRIBUTING.md](https://github.com/nf-core/sarek/tree/master/.github/CONTRIBUTING.md)
-->

## PR checklist

- [ ] This comment contains a description of changes (with reason).
- [ ] If you've fixed a bug or added code that should be tested, add
tests!
- [ ] If you've added a new tool - have you followed the pipeline
conventions in the [contribution
docs](https://github.com/nf-core/sarek/tree/master/.github/CONTRIBUTING.md)
- [ ] If necessary, also make a PR on the nf-core/sarek _branch_ on the
[nf-core/test-datasets](https://github.com/nf-core/test-datasets)
repository.
- [ ] Make sure your code lints (`nf-core lint`).
- [ ] Ensure the test suite passes (`nextflow run . -profile test,docker
--outdir <OUTDIR>`).
- [ ] Check for unexpected warnings in debug mode (`nextflow run .
-profile debug,test,docker --outdir <OUTDIR>`).
- [ ] Usage Documentation in `docs/usage.md` is updated.
- [ ] Output Documentation in `docs/output.md` is updated.
- [ ] `CHANGELOG.md` is updated.
- [ ] `README.md` is updated (including new tool citations and
authors/contributors).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxulysse maxulysse

Labels
docs good first issue Good for newcomers
Projects
No open projects
Hackathon October 2024
Status: Done
Milestone
3.5
Development

No branches or pull requests
3 participants
@maxulysse @FriederikeHanssen @asp8200