Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running the annotation step does not work with the full samplesheet file described on the website or with the variantcalling.csv file generated by the pipeline in a previous step #949

Closed
MolPath-Bioinfo opened this issue Feb 22, 2023 · 6 comments · Fixed by #1048
Assignees
Labels
bug Something isn't working input validation
Milestone

Comments

@MolPath-Bioinfo
Copy link

Description of the bug

Running only the annotation step using the csv file generated by the Sarek 3.1.2 pipeline in a previous run (variantcaller.csv) ends with the following error:

The sample-sheet only contains normal-samples, but the following tools, which were requested with "--tools", expect at least one tumor-sample : mutect2

The content of the variantcaller.csv corresponds to the full samplesheet described on the website and has the following format:

patient,sample,variantcaller,vcf
P1,H-2022-09665,mutect2,H-2022-09665.mutect2.filtered.vcf.gz
P1,H-2022-09665,strelka,H-2022-09665.strelka.variants.vcf.gz

Solution: adding the columns sex and status to the input file (directly after the patient column) solves the problem

patient,sex,status.sample,variantcaller,vcf
P1,XX,1,H-2022-09665,mutect2,H-2022-09665.mutect2.filtered.vcf.gz
P1,XX,1,H-2022-09665,strelka,H-2022-09665.strelka.variants.vcf.gz

The documentation on the website needs to be adapted and the 2 columns added to the full samplesheet example.

This behavior is not consistent in all steps. If I run the pipeline from the beginning with the tools
--tools mutect2,strelka,vep
then the error does not occur.

The columns sex and status seems to be required in all cases when one runs the individual steps using the --step parameter. I encountered this also while running only the variant calling step.

Command used and terminal output

nextflow run /home/thiele/local_apps/nf-core-sarek-3.1.2/workflow -profile singularity -c "/mnt/Molpath/users/mihaela/projects/variant_calling/WES/220728_A01542_0030_AHNCCMDRXY_3Aug_TWIST/VIP_tumorOnly/config/nf_wes.config" -params-file "/mnt/Molpath/users/mihaela/projects/variant_calling/WES/220728_A01542_0030_AHNCCMDRXY_3Aug_TWIST/VIP_tumorOnly/config/nf_params.json" --step annotate --vep_species "homo_sapiens" --vep_version '106.1' --vep_include_fasta --vep_loftee --vep_spliceregion


The sample-sheet only contains normal-samples, but the following tools, which were requested with "--tools", expect at least one tumor-sample : mutect2

Relevant files

No response

System information

  • System: Linux 5.4.0-136-generic Ubuntu
  • nf-core/sarek 3.1.2
  • executor: local
  • hardware: Desktop
  • nextflow version: 22.10.4 build 5836
  • container engine: Singularity
@MolPath-Bioinfo MolPath-Bioinfo added the bug Something isn't working label Feb 22, 2023
@FriederikeHanssen
Copy link
Contributor

See also #948

@FriederikeHanssen
Copy link
Contributor

FriederikeHanssen commented Mar 27, 2023

Hi Mihaela! Is this working when just status?

@FriederikeHanssen
Copy link
Contributor

hm I am thinking about this issue. and it should probably fail: mutect2 is not an annotation tool, but it starts from --step annotate, so it should fail but for a different reason

@MolPath-Bioinfo
Copy link
Author

MolPath-Bioinfo commented Mar 27, 2023 via email

@MolPath-Bioinfo
Copy link
Author

MolPath-Bioinfo commented Mar 27, 2023 via email

@keslingmj keslingmj self-assigned this Mar 28, 2023
@FriederikeHanssen FriederikeHanssen moved this from Todo to In Progress in nf-core Hackathon March 2023 Mar 29, 2023
@FriederikeHanssen
Copy link
Contributor

Tool validation will now be skipped if --step annotateis run. However, if starting from annotation, there shouldn't be any need to set a variant caller

@FriederikeHanssen FriederikeHanssen linked a pull request May 29, 2023 that will close this issue
9 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in nf-core Hackathon March 2023 May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working input validation
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants