Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHORES: update TEMPLATE with 2.8 #1011

Merged
merged 7 commits into from
May 3, 2023
Merged

CHORES: update TEMPLATE with 2.8 #1011

merged 7 commits into from
May 3, 2023

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@maxulysse
Copy link
Member Author

Replace #1010

maxulysse
maxulysse commented May 3, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
maxulysse
maxulysse commented May 3, 2023
View reviewed changes
docs/usage.md Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented May 3, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 627facf

+| ✅ 153 tests passed       |+
#| ❔   9 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-05-03 13:29:23

@maxulysse
Copy link
Member Author

@nf-core-bot fix linting pretty please 🙏

FriederikeHanssen
FriederikeHanssen approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merci 🙏

@FriederikeHanssen
Copy link
Contributor

I think prettier doesn't like the line breaks in the modules.config

@maxulysse
Copy link
Member Author

I agree, but it's coming from tools, and locally my prettier is not picking it up, so waiting for the bot

@maxulysse
Copy link
Member Author

Actually it was a missing bracket

@maxulysse maxulysse merged commit fb49206 into nf-core:dev May 3, 2023
@maxulysse maxulysse deleted the sync_2.8 branch May 3, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrtalbot adamrtalbot adamrtalbot approved these changes

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxulysse @FriederikeHanssen @adamrtalbot @nf-core-bot