Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: pattern for fasta file #1055

Merged
merged 4 commits into from
Jun 2, 2023
Merged

FIX: pattern for fasta file #1055

merged 4 commits into from
Jun 2, 2023

Conversation

maxulysse
Copy link
Member

Fix pattern for fasta file in the json schema

@maxulysse maxulysse mentioned this pull request Jun 1, 2023
Merged
6 tasks
FriederikeHanssen
FriederikeHanssen reviewed Jun 2, 2023
View reviewed changes
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can all tools with gz fasta?

@maxulysse
Copy link
Member Author

Can all tools with gz fasta?

no, but we'll add a uncompress step in coming release.
The .gz was a part of the template I forgot to remove, and wanted just to fix the pattern here

@maxulysse maxulysse merged commit 2848c6d into dev Jun 2, 2023
@maxulysse maxulysse deleted the json_fix branch June 2, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen left review comments

@JoseEspinosa JoseEspinosa JoseEspinosa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxulysse @JoseEspinosa @FriederikeHanssen