Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ascat manual test #1093

Merged
merged 3 commits into from
Jun 9, 2023
Merged

Fix ascat manual test #1093

merged 3 commits into from
Jun 9, 2023

Conversation

asp8200
Copy link
Contributor

@asp8200 asp8200 commented Jun 9, 2023 •
edited
Loading

I think there is a good chance this solves #1020. The issue message in #1020 is certainly identical to the one I was struggling with.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@asp8200 asp8200 requested a review from maxulysse as a code owner June 9, 2023 20:11
@github-actions
Copy link

github-actions bot commented Jun 9, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit c3eb660

+| ✅ 154 tests passed       |+
#| ❔   9 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-06-09 20:36:58

@maxulysse maxulysse merged commit ecb49a8 into dev Jun 9, 2023
@asp8200 asp8200 deleted the fix_ascat_manual_test branch June 9, 2023 22:02
@asp8200 asp8200 mentioned this pull request Jun 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asp8200 @maxulysse