Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Refactor prefix definition #1108

Merged
merged 4 commits into from
Jun 14, 2023
Merged

FIX: Refactor prefix definition #1108

merged 4 commits into from
Jun 14, 2023

Conversation

maxulysse
Copy link
Member

Fix #938

@github-actions
Copy link

github-actions bot commented Jun 14, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 6276707

+| ✅ 153 tests passed       |+
#| ❔   9 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-06-14 15:07:18

@robsyme
Copy link
Contributor

robsyme commented Jun 14, 2023

One note - there is in important difference between path.baseName and path.name - the .getBaseName() method (defined in Nextflow) will strip out one extension.

@maxulysse
Copy link
Member Author

One note - there is in important difference between path.baseName and path.name - the .getBaseName() method (defined in Nextflow) will strip out one extension.

There is the .getSimpleName() too to remove all extensions, right?

robsyme
robsyme reviewed Jun 14, 2023
View reviewed changes
conf/modules/joint_germline.config Outdated Show resolved Hide resolved
conf/modules/modules.config Outdated Show resolved Hide resolved
conf/modules/modules.config Outdated Show resolved Hide resolved
conf/modules/annotate.config Show resolved Hide resolved
conf/modules/annotate.config Outdated Show resolved Hide resolved
conf/modules/annotate.config Outdated Show resolved Hide resolved
@maxulysse @robsyme
Update conf/modules/joint_germline.config
febf7d8 
Co-authored-by: Robert Syme <rob.syme@gmail.com>
robsyme
robsyme approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@robsyme robsyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the tests pass, these look good.

asp8200 added a commit that referenced this pull request Jun 14, 2023
@asp8200
Related to PR FIX: Refactor prefix definition #1108
67499b6
@maxulysse maxulysse merged commit abc7fe6 into nf-core:dev Jun 14, 2023
@maxulysse maxulysse deleted the remove_minus branch June 14, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robsyme robsyme robsyme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @robsyme