Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating multiqc to v1.15 #1174

Merged
merged 3 commits into from
Aug 7, 2023
Merged

Updating multiqc to v1.15 #1174

merged 3 commits into from
Aug 7, 2023

Conversation

asp8200
Copy link
Contributor

@asp8200 asp8200 commented Aug 5, 2023

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Aug 5, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit a83533b

+| ✅ 151 tests passed       |+
#| ❔   9 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-08-05 17:01:08

FriederikeHanssen
FriederikeHanssen reviewed Aug 5, 2023
View reviewed changes
CHANGELOG.md
Comment on lines 23 to +24
- [#1160](https://github.com/nf-core/sarek/pull/1160) - Updating tiddit to v3.6.1
- [#1174](https://github.com/nf-core/sarek/pull/1174) - Updating multiqc to v1.15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a table at the bottom of the release section that should list all updates. Can you put this there? It helps getting a quicker overview on version changes on release

@asp8200 asp8200 marked this pull request as ready for review August 5, 2023 17:13
@asp8200 asp8200 requested a review from maxulysse as a code owner August 5, 2023 17:13
@FriederikeHanssen FriederikeHanssen merged commit f1b9ad9 into nf-core:dev Aug 7, 2023
@asp8200 asp8200 deleted the update_multiqc branch October 6, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

@maxulysse maxulysse Awaiting requested review from maxulysse maxulysse is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asp8200 @FriederikeHanssen