Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: fix mutect2 meta id issue in tumor_only workflow #1215

Merged
merged 3 commits into from
Sep 7, 2023
Merged

FIX: fix mutect2 meta id issue in tumor_only workflow #1215

merged 3 commits into from
Sep 7, 2023

Conversation

maxulysse
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 7, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit b7253f6

+| ✅ 140 tests passed       |+
#| ❔   9 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-09-07 12:45:35

@asp8200
Copy link
Contributor

asp8200 commented Sep 7, 2023

Did the local/manuel test "Run joint calling on tumor only samples with mutect2" pass on this PR?

@maxulysse
Copy link
Member Author

Did the local/manuel test "Run joint calling on tumor only samples with mutect2" pass on this PR?

I created this PR to fix just that test, I managed to run the same command, but haven't re-run the pytest, let me do that before we merge

@maxulysse
Copy link
Member Author

Taking forever on my tiny computer, so merging. Can you try out on your side, your machine is faster

@maxulysse maxulysse merged commit c695d25 into nf-core:dev Sep 7, 2023
32 checks passed
@maxulysse maxulysse deleted the mutect2_intervals branch September 7, 2023 14:12
@asp8200
Copy link
Contributor

asp8200 commented Sep 7, 2023

It also takes a loong time on my machine, but I'll kick it off now on the dev-branch

@maxulysse
Copy link
Member Author

I thought you were doing all that on a bigger machine, not your own, to be honest.
Otherwise I would have continue on my side

@asp8200
Copy link
Contributor

asp8200 commented Sep 7, 2023

Well, I'm doing it on an aws-ec2. It has more muscles than my laptop

@FriederikeHanssen
Copy link
Contributor

Taking forever on my tiny computer, so merging. Can you try out on your side, your machine is faster

I think soon you get 🤠 :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxulysse @asp8200 @FriederikeHanssen