Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version of BCFTOOLS_SORT-module with '--temp-dir .' added as opti… #1224

Merged
merged 4 commits into from
Sep 12, 2023
Merged

New version of BCFTOOLS_SORT-module with '--temp-dir .' added as opti… #1224

merged 4 commits into from
Sep 12, 2023

Conversation

asp8200
Copy link
Contributor

@asp8200 asp8200 commented Sep 12, 2023 •
edited
Loading

New version of BCFTOOLS_SORT-module with --temp-dir . added as option for bcftools sort.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Sep 12, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit ee9e561

+| ✅ 140 tests passed       |+
#| ❔   9 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-09-12 09:15:58

@maxulysse
Copy link
Member

Can you update CHANGELOG too?

@asp8200
Copy link
Contributor Author

asp8200 commented Sep 12, 2023

Can you update CHANGELOG too?

You don't read the description of PR's, do you? 😁

@asp8200 asp8200 marked this pull request as ready for review September 12, 2023 09:14
@asp8200 asp8200 requested a review from maxulysse as a code owner September 12, 2023 09:14
@asp8200 asp8200 requested a review from SPPearce September 12, 2023 09:25
maxulysse
maxulysse reviewed Sep 12, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@asp8200 @maxulysse
Update CHANGELOG.md
87d74e8 
Co-authored-by: Maxime U Garcia <max.u.garcia@gmail.com>
@asp8200 asp8200 merged commit 4f1a9fc into dev Sep 12, 2023
27 checks passed
@asp8200 asp8200 deleted the update_bcftools_sort branch September 12, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

@SPPearce SPPearce Awaiting requested review from SPPearce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asp8200 @maxulysse