Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Back to dev #1231

Merged
merged 5 commits into from
Sep 14, 2023
Merged

Back to dev #1231

merged 5 commits into from
Sep 14, 2023

Conversation

asp8200
Copy link
Contributor

@asp8200 asp8200 commented Sep 14, 2023

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Sep 14, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit d22d60b

+| ✅ 141 tests passed       |+
#| ❔  10 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-09-14 07:57:41

@asp8200 asp8200 changed the title Prepare release 3 4 Back to dev Sep 14, 2023
@asp8200 @FriederikeHanssen
Update CHANGELOG.md
24f3dfe 
Co-authored-by: Friederike Hanssen <Friederike.hanssen@qbic.uni-tuebingen.de>
@asp8200 asp8200 marked this pull request as ready for review September 14, 2023 07:53
@FriederikeHanssen
Copy link
Contributor

@nf-core-bot fix linting

@asp8200 asp8200 merged commit 8c167bf into nf-core:dev Sep 14, 2023
20 checks passed
@asp8200 asp8200 deleted the prepare_release_3_4 branch September 14, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen left review comments

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asp8200 @FriederikeHanssen @maxulysse @nf-core-bot