-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Ascat R script execution #127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I'm just waiting if it works on our server as well, I'll likely merge it tomorrow
It would be good to finally manage to make files so that we could CI the ASCAT processes as well. |
While we're at it, may I suggest we improve the ASCAT process with:
to replace Lines 2598 to 2611 in d1a5691
|
But I could do that in a separate PR if you prefer |
It's all good, however you like, let me just test first if the param name thing fixed the issue, then I can add it here |
And I can also help with adding tests for ASCAT, if you like |
That would be amazing if we could do that |
Worked on my side, with the |
ok just added your suggestion |
Co-Authored-By: Maxime Garcia <maxime.garcia@scilifelab.se>
Fixes Ascat R script executions
PR checklist
nextflow run . -profile test,docker
).nf-core lint .
).docs
is updatedCHANGELOG.md
is updatedREADME.md
is updatedLearn more about contributing: CONTRIBUTING.md