Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using process.containerOptions instead of docker.runOptions #1431

Merged
merged 7 commits into from
Mar 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [#1419](https://github.com/nf-core/sarek/pull/1419) - Updating GATK to v4.5, and updating samtools to v1.19.2 in GATK/markduplicates.
- [#1426](https://github.com/nf-core/sarek/pull/1426) - Updating certain modules in order to fix the testdata-path in the nf-tests of those modules. Setting Docker runOptions for params.use_gatk_spark.
- [#1428](https://github.com/nf-core/sarek/pull/1428) - Sync `TEMPLATE` with `tools` `2.13.1`
- [#1431](https://github.com/nf-core/sarek/pull/1431) - Using docker.containerOptions instead of docker.runOptions. Clearing containerOptions for SPARK modules for any kind of supported container engine.

### Fixed

Expand Down
1 change: 1 addition & 0 deletions conf/modules/markduplicates.config
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ process {
}

withName: 'GATK4SPARK_MARKDUPLICATES' {
containerOptions = ''
ext.args = { '--remove-sequencing-duplicates false -VS LENIENT' }
ext.prefix = { "${meta.id}.md.cram" }
publishDir = [
Expand Down
3 changes: 3 additions & 0 deletions conf/modules/prepare_recalibration.config
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
process {

withName: 'GATK4_BASERECALIBRATOR|GATK4SPARK_BASERECALIBRATOR' {
if (params.use_gatk_spark) {
containerOptions = ''
}
ext.prefix = { meta.num_intervals <= 1 ? "${meta.id}.recal" : "${meta.id}_${intervals.simpleName}.recal" }
publishDir = [
mode: params.publish_dir_mode,
Expand Down
3 changes: 3 additions & 0 deletions conf/modules/recalibrate.config
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
process {

withName: 'GATK4_APPLYBQSR|GATK4SPARK_APPLYBQSR' {
if (params.use_gatk_spark) {
containerOptions = ''
}
ext.prefix = { meta.num_intervals <= 1 ? "${meta.id}.recal" : "${meta.id}_${intervals.baseName}.recal" }
publishDir = [
mode: params.publish_dir_mode,
Expand Down
2 changes: 1 addition & 1 deletion conf/test.config
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ if (System.getenv('PROFILE')) {
} else if ("$PROFILE" == "docker") {
conda.enabled = false
docker.enabled = true
docker.runOptions = { params.use_gatk_spark ? '' : '-u $(id -u):$(id -g)' }.call()
process.containerOptions = '-u $(id -u):$(id -g)'
charliecloud.enabled = false
podman.enabled = false
shifter.enabled = false
Expand Down
2 changes: 1 addition & 1 deletion conf/test/cache.config
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ if (System.getenv('PROFILE')) {
} else if ("$PROFILE" == "docker") {
conda.enabled = false
docker.enabled = true
docker.runOptions = { params.use_gatk_spark ? '' : '-u $(id -u):$(id -g)' }.call()
process.containerOptions = '-u $(id -u):$(id -g)'
charliecloud.enabled = false
podman.enabled = false
shifter.enabled = false
Expand Down
2 changes: 0 additions & 2 deletions conf/test/use_gatk_spark.config
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,3 @@ params {
use_gatk_spark = 'baserecalibrator,markduplicates'
input = "${projectDir}/tests/csv/3.0/fastq_tumor_only.csv"
}

docker.runOptions = ''
18 changes: 9 additions & 9 deletions nextflow.config
Original file line number Diff line number Diff line change
Expand Up @@ -186,17 +186,17 @@ profiles {
singularity.enabled = false
}
docker {
apptainer.enabled = false
charliecloud.enabled = false
conda.enabled = false
docker.enabled = true
podman.enabled = false
shifter.enabled = false
docker.runOptions = { params.use_gatk_spark ? '' : '-u $(id -u):$(id -g)' }.call()
singularity.enabled = false
apptainer.enabled = false
charliecloud.enabled = false
conda.enabled = false
docker.enabled = true
podman.enabled = false
shifter.enabled = false
process.containerOptions = '-u $(id -u):$(id -g)'
singularity.enabled = false
}
arm {
docker.runOptions = '-u $(id -u):$(id -g) --platform=linux/amd64'
process.containerOptions = '-u $(id -u):$(id -g) --platform=linux/amd64'
}
singularity {
apptainer.enabled = false
Expand Down
Loading