Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws megatests GH actions #150

Merged
merged 4 commits into from
Mar 6, 2020
Merged

Update aws megatests GH actions #150

merged 4 commits into from
Mar 6, 2020

Conversation

ggabernet
Copy link
Member

nf-core/sarek pull request

Fix --outdir param

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@ggabernet ggabernet requested a review from maxulysse as a code owner March 6, 2020 15:15
@maxulysse
Copy link
Member

I think you still have issues with the credentials

@ggabernet
Copy link
Member Author

https://github.com/nf-core/sarek/settings/secrets

So it seems like secrets are not passed to pull requests, so we would need to merge to fully test it.
It also makes sense, as otherwise, anyone making a PR could use our secrets for testing :)

@maxulysse maxulysse merged commit a6037cd into nf-core:dev Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants