Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix R scripts #16

Merged
merged 3 commits into from
Jun 24, 2019
Merged

Fix R scripts #16

merged 3 commits into from
Jun 24, 2019

Conversation

maxulysse
Copy link
Member

  • Make scripts in bin/ and in scripts/ executable (chmod +x)
  • Fix path to Rscript (/bin/env doesn't exist)

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/sarek/tree/master/.github/CONTRIBUTING.md

szilvajuhos
szilvajuhos approved these changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@szilvajuhos szilvajuhos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK

@maxulysse maxulysse merged commit 10eff4e into nf-core:dev Jun 24, 2019
@nf-core-bot nf-core-bot mentioned this pull request Jul 4, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szilvajuhos szilvajuhos szilvajuhos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @szilvajuhos