Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve variant calling documentation #174

Merged
merged 22 commits into from
Apr 2, 2020
Merged

improve variant calling documentation #174

merged 22 commits into from
Apr 2, 2020

Conversation

ggabernet
Copy link
Member

@ggabernet ggabernet commented Apr 2, 2020 •
edited
Loading

nf-core/sarek pull request

  • improve variant calling documentation

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

maxulysse
maxulysse reviewed Apr 2, 2020
View reviewed changes
docs/README.md Outdated Show resolved Hide resolved
maxulysse
maxulysse reviewed Apr 2, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
maxulysse
maxulysse reviewed Apr 2, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
maxulysse
maxulysse reviewed Apr 2, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
maxulysse
maxulysse reviewed Apr 2, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
maxulysse
maxulysse reviewed Apr 2, 2020
View reviewed changes
docs/variant_calling.md Outdated Show resolved Hide resolved
maxulysse
maxulysse reviewed Apr 2, 2020
View reviewed changes
docs/variant_calling.md Outdated Show resolved Hide resolved
ggabernet and others added 5 commits April 2, 2020 17:38
@ggabernet @maxulysse
Update CHANGELOG.md
c59c42b 
Co-Authored-By: Maxime Garcia <maxime.garcia@scilifelab.se>
@ggabernet @maxulysse
Update docs/variant_calling.md
2e51f35 
Co-Authored-By: Maxime Garcia <maxime.garcia@scilifelab.se>
@ggabernet @maxulysse
Update docs/variant_calling.md
d3bb236 
Co-Authored-By: Maxime Garcia <maxime.garcia@scilifelab.se>
@ggabernet
apply code review suggestions
3a277ed
@ggabernet
Merge branch 'dev' of https://github.com/ggabernet/nf-core-sarek into…
d9372da 
… dev
maxulysse
maxulysse reviewed Apr 2, 2020
View reviewed changes
README.md Show resolved Hide resolved
maxulysse
maxulysse reviewed Apr 2, 2020
View reviewed changes
docs/variant_calling.md Outdated Show resolved Hide resolved
maxulysse
maxulysse reviewed Apr 2, 2020
View reviewed changes
docs/variant_calling.md Outdated Show resolved Hide resolved
maxulysse
maxulysse reviewed Apr 2, 2020
View reviewed changes
docs/variant_calling.md Outdated Show resolved Hide resolved
maxulysse
maxulysse reviewed Apr 2, 2020
View reviewed changes
docs/variant_calling.md Outdated Show resolved Hide resolved
maxulysse
maxulysse reviewed Apr 2, 2020
View reviewed changes
docs/variant_calling.md Outdated Show resolved Hide resolved
ggabernet and others added 8 commits April 2, 2020 17:47
@ggabernet @maxulysse
Update docs/variant_calling.md
1934152 
Co-Authored-By: Maxime Garcia <maxime.garcia@scilifelab.se>
@ggabernet @maxulysse
Update docs/variant_calling.md
195d507 
Co-Authored-By: Maxime Garcia <maxime.garcia@scilifelab.se>
@ggabernet @maxulysse
Update docs/variant_calling.md
fdd9682 
Co-Authored-By: Maxime Garcia <maxime.garcia@scilifelab.se>
@ggabernet @maxulysse
Update docs/variant_calling.md
4889e1b 
Co-Authored-By: Maxime Garcia <maxime.garcia@scilifelab.se>
@ggabernet @maxulysse
Update docs/variant_calling.md
e2a9959 
Co-Authored-By: Maxime Garcia <maxime.garcia@scilifelab.se>
@ggabernet @maxulysse
Update docs/variant_calling.md
bb4435c 
Co-Authored-By: Maxime Garcia <maxime.garcia@scilifelab.se>
@ggabernet
Merge branch 'dev' of https://github.com/ggabernet/nf-core-sarek into…
a6a7bc1 
… dev
@ggabernet @maxulysse
Update docs/variant_calling.md
07b6678 
Co-Authored-By: Maxime Garcia <maxime.garcia@scilifelab.se>
maxulysse
maxulysse approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful

@maxulysse
Copy link
Member

Any idea why you have 46 checks, and I got just 23 on #175
It seems that you have twice the usual number of checks.
(given the numbers and the duplication, can't help but thinking about chromosomes and cell division...)

@ggabernet
Copy link
Member Author

No idea, but it looks like each test is running twice

@maxulysse maxulysse merged commit 9fb083f into nf-core:dev Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggabernet @maxulysse