Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some Sentieon issues #178

Merged
merged 18 commits into from
Apr 22, 2020
Merged

Fix some Sentieon issues #178

merged 18 commits into from
Apr 22, 2020

Conversation

maxulysse
Copy link
Member

nf-core/sarek pull request

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@maxulysse maxulysse added the enhancement New feature or request label Apr 8, 2020
@maxulysse maxulysse added this to the 2.6 milestone Apr 8, 2020
@maxulysse maxulysse self-assigned this Apr 8, 2020
@maxulysse maxulysse marked this pull request as ready for review April 17, 2020 14:37
Copy link
Contributor

@szilvajuhos szilvajuhos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, tested on one sample on munin, gives the expected results

@maxulysse maxulysse merged commit c1bdcbf into nf-core:dev Apr 22, 2020
@maxulysse maxulysse deleted the Sentieon branch April 22, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants