Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory parameter singleCPUMem is now possible to use #22

Merged
merged 4 commits into from
Sep 2, 2019

Conversation

alneberg
Copy link
Member

@alneberg alneberg commented Aug 13, 2019

The --singleCPUMem parameter was not possible to use on the commandline as it was interpretted as a string instead of a memory unit. This PR fixes this problem.

PR checklist

  • This comment contains a description of changes (with reason)
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • CHANGELOG.md is updated

@maxulysse maxulysse self-requested a review August 13, 2019 12:39
@maxulysse
Copy link
Member

Should we check if similar issues arise with --max_memory, --max_cpus, --max_time?

@maxulysse
Copy link
Member

No need to fix this line?

memory = {check_resource(params.singleCPUMem * task.attempt)}

conf/base.config Outdated Show resolved Hide resolved
@maxulysse maxulysse added the bug Something isn't working label Aug 16, 2019
@maxulysse maxulysse self-assigned this Aug 16, 2019
@maxulysse maxulysse merged commit c0d69e1 into nf-core:dev Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants