Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion to DSL2 #234

Merged
merged 12 commits into from
Jul 15, 2020
Merged

Conversion to DSL2 #234

merged 12 commits into from
Jul 15, 2020

Conversation

ggabernet
Copy link
Member

This is a first draft to convert Sarek to DSL2

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

${colors.blue} | \\| | \\__, \\__/ | \\ |___ ${colors.green}\\`-._,-`-,${colors.reset}
${colors.green}`._,._,\'${colors.reset}
${colors.purple} ${workflow.manifest.name} v${workflow.manifest.version}${colors.reset}
-${colors.dim}----------------------------------------------------${colors.reset}-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the sarek ascii art?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes right you have the Sarek logo there as well! Of course!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking we could merge this PR and then work on these things in parallel?

@maxulysse maxulysse added the enhancement New feature or request label Jul 14, 2020
@maxulysse maxulysse added this to the 3.0 milestone Jul 14, 2020
Co-authored-by: FriederikeHanssen <friederike.hanssen@student.uni-tuebingen.de>
Co-authored-by: Maxime Garcia <maxime.garcia@scilifelab.se>
…bingen.de>

Co-authored-by: Maxime Garcia <maxime.garcia@scilifelab.se>
update get_software_versions
Co-authored-by: FriederikeHanssen <friederike.hanssen@student.uni-tuebingen.de>
Co-authored-by: Maxime Garcia <maxime.garcia@scilifelab.se>
Co-authored-by: FriederikeHanssen <friederike.hanssen@student.uni-tuebingen.de>
@ggabernet ggabernet marked this pull request as ready for review July 15, 2020 08:07
@ggabernet ggabernet merged commit 9d1087b into nf-core:dsl2 Jul 15, 2020
@maxulysse maxulysse added the DSL2 label Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants