Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MarkDuplicates #250

Merged
merged 2 commits into from
Jul 19, 2020
Merged

Add MarkDuplicates #250

merged 2 commits into from
Jul 19, 2020

Conversation

FriederikeHanssen
Copy link
Contributor

nf-core/sarek pull request

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

ggabernet
ggabernet approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Let's not forget to add it to the MultiQC process as well though

@FriederikeHanssen
Copy link
Contributor Author

Good point! I will add before merging, ok?

@FriederikeHanssen
Copy link
Contributor Author

Tested conditional execution, i.e. setting --skip_markduplicates

@maxulysse
Copy link
Member

It's look amazing, we're progressing fast

@FriederikeHanssen FriederikeHanssen merged commit 55e1679 into nf-core:dsl2 Jul 19, 2020
@maxulysse maxulysse added the DSL2 label Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggabernet ggabernet ggabernet approved these changes

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FriederikeHanssen @maxulysse @ggabernet