Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add UMI testing + update docs #253

Merged
merged 8 commits into from
Jul 24, 2020
Merged

add UMI testing + update docs #253

merged 8 commits into from
Jul 24, 2020

Conversation

maxulysse
Copy link
Member

nf-core/sarek pull request

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@maxulysse maxulysse requested a review from a team July 23, 2020 10:20
@maxulysse
Copy link
Member Author

@chelauk @nibscles UMI is now CI tested :-D
Thanks a lot @nibscles for your help on that matter.
Sorry I got delayed to finish working on that.

@maxulysse maxulysse merged commit 0f76f8c into nf-core:dev Jul 24, 2020
@maxulysse maxulysse deleted the umi branch July 24, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants