Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs and comments #255

Merged
merged 3 commits into from
Jul 23, 2020
Merged

update docs and comments #255

merged 3 commits into from
Jul 23, 2020

Conversation

maxulysse
Copy link
Member

nf-core/sarek pull request

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

CHANGELOG.md Show resolved Hide resolved
maxulysse added a commit to maxulysse/nf-core_sarek that referenced this pull request Jul 23, 2020
Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess fine, but see my comment. Resolved the merge conflict for u.

nextflow.config Show resolved Hide resolved
@maxulysse
Copy link
Member Author

Guess fine, but see my comment.

Replied ;-)

Resolved the merge conflict for u.

Thanks,
I've been looking for updating PRs since they changed the GUI, where is it now?

@apeltzer
Copy link
Member

I've been looking for updating PRs since they changed the GUI, where is it now?

Its down below the checks now, at least was for me :-)

@maxulysse maxulysse merged commit d855bd8 into nf-core:dev Jul 23, 2020
@maxulysse maxulysse deleted the docs branch July 23, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants