Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issus due to merging with TEMPLATE #262

Merged
merged 11 commits into from
Aug 3, 2020
Merged

Fix issus due to merging with TEMPLATE #262

merged 11 commits into from
Aug 3, 2020

Conversation

maxulysse
Copy link
Member

nf-core/sarek pull request

Fix linting (and other) errors due to merging #260

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@maxulysse maxulysse marked this pull request as draft July 31, 2020 15:14
@maxulysse
Copy link
Member Author

Just need to improve JSON, and we're back to a fully linted dev

@maxulysse maxulysse requested a review from a team July 31, 2020 21:34
@maxulysse maxulysse marked this pull request as ready for review July 31, 2020 21:34
ggabernet
ggabernet approved these changes Aug 1, 2020
View reviewed changes
Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe the Changelog should be updated as well though :)

@maxulysse
Copy link
Member Author

I knew I had forgotten something

@maxulysse maxulysse merged commit 6cf70b4 into nf-core:dev Aug 3, 2020
@maxulysse maxulysse deleted the SYNC branch August 3, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggabernet ggabernet ggabernet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @ggabernet