-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHubActions #27
Conversation
e190326
to
5728056
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK, but would be better to be reviewed by somebody who is more experienced in github stuff.
I think at the moment, that would be me ;-) |
Good work @maxulysse ! So the only difference I can see between the Travis CI tests and GitHub Actions are the two additional files |
Much quicker than Travis too! |
Files are indeed auto-detected and triggered when place in I could have put all tests into one file, but I figured that it would be better to run both tests separately as we don't need to download the docker image as well for the linting. It's also much easier to make a matrix with ENV variables so you can more easily test multiple versions of different tools, or in sarek case, make multiple tests. And I just scratched the surface with linting and CI, we could automate responses on PR and issues and so on... |
And then we can all look at nf-core/tools#369 ;-) |
Amazing job! Looks really good to me and I also like that you can split the lint and the actual tests in separate files... |
PR checklist
nextflow run . -profile test,docker
).nf-core lint .
).docs
is updatedCHANGELOG.md
is updatedREADME.md
is updatedLearn more about contributing: https://github.com/nf-core/sarek/tree/master/.github/CONTRIBUTING.md