Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHubActions #27

Merged
merged 45 commits into from
Sep 3, 2019
Merged

Add GitHubActions #27

merged 45 commits into from
Sep 3, 2019

Conversation

maxulysse
Copy link
Member

@maxulysse maxulysse commented Aug 19, 2019

  • Add GitHub Actions

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/sarek/tree/master/.github/CONTRIBUTING.md

@maxulysse maxulysse self-assigned this Aug 20, 2019
@maxulysse maxulysse added the enhancement New feature or request label Aug 20, 2019
Copy link
Contributor

@szilvajuhos szilvajuhos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, but would be better to be reviewed by somebody who is more experienced in github stuff.

@maxulysse
Copy link
Member Author

I think at the moment, that would be me ;-)

@maxulysse maxulysse requested a review from a team August 28, 2019 07:59
@drpatelh
Copy link
Member

Good work @maxulysse ! So the only difference I can see between the Travis CI tests and GitHub Actions are the two additional files .github/workflows/ci.yml and .github/workflows/linting.yml ? These look much simpler and I think its probably nicer to have these two tests running separately. Are these file auto-detected and triggered on GitHub Actions if they are placed in .github/workflows/?

@drpatelh
Copy link
Member

Much quicker than Travis too!

@maxulysse
Copy link
Member Author

Files are indeed auto-detected and triggered when place in .github/workflows/.

I could have put all tests into one file, but I figured that it would be better to run both tests separately as we don't need to download the docker image as well for the linting.

It's also much easier to make a matrix with ENV variables so you can more easily test multiple versions of different tools, or in sarek case, make multiple tests.

And I just scratched the surface with linting and CI, we could automate responses on PR and issues and so on...

@drpatelh
Copy link
Member

Yeah, I saw the matrix testing from the number of checks that were carried out. Definitely a great start. Thanks for doing this! It looks good enough to me but maybe @ewels @sven1103 want to give it a once over too?

@maxulysse
Copy link
Member Author

And then we can all look at nf-core/tools#369 ;-)

@apeltzer
Copy link
Member

apeltzer commented Sep 3, 2019

Amazing job! Looks really good to me and I also like that you can split the lint and the actual tests in separate files...

@maxulysse maxulysse merged commit 2647ec1 into nf-core:dev Sep 3, 2019
@maxulysse maxulysse deleted the GitHubActions branch September 3, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants