Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs #29

Merged
merged 6 commits into from
Aug 28, 2019
Merged

Update docs #29

merged 6 commits into from
Aug 28, 2019

Conversation

maxulysse
Copy link
Member

  • Rename params skip to skipQC
  • Update docs about skipQC params

Many thanks to contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/sarek/tree/master/.github/CONTRIBUTING.md

@maxulysse maxulysse self-assigned this Aug 27, 2019
@maxulysse maxulysse added enhancement New feature or request docs labels Aug 27, 2019
szilvajuhos
szilvajuhos approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@szilvajuhos szilvajuhos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci

@maxulysse maxulysse merged commit 04cb96e into nf-core:dev Aug 28, 2019
@maxulysse maxulysse deleted the skipQC branch August 28, 2019 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szilvajuhos szilvajuhos szilvajuhos approved these changes

Assignees

@maxulysse maxulysse

Labels
docs enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @szilvajuhos