Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add somatic to DSL2 #297

Merged
merged 17 commits into from
Jan 27, 2021
Merged

Add somatic to DSL2 #297

merged 17 commits into from
Jan 27, 2021

Conversation

maxulysse
Copy link
Member

nf-core/sarek pull request

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@maxulysse maxulysse added the DSL2 label Oct 22, 2020
@FriederikeHanssen
Copy link
Contributor

FYI: I think the BioContainers for bwa-mem2 have been updated. It is not shown yet on the website but they are listed on https://quay.io/repository/biocontainers/bwa-mem2?tab=tags and https://depot.galaxyproject.org/singularity/ . Mulled container is still missing though as far as I see: https://quay.io/repository/biocontainers/mulled-v2-fe8faa35dbf6dc65a0f7f5d4ea12e31a79f73e40?tab=tags

@maxulysse maxulysse closed this Jan 26, 2021
@maxulysse maxulysse deleted the branch nf-core:dsl2 January 26, 2021 20:36
@maxulysse maxulysse reopened this Jan 26, 2021
@maxulysse maxulysse marked this pull request as ready for review January 27, 2021 16:51
@maxulysse maxulysse requested a review from a team January 27, 2021 16:51
@FriederikeHanssen
Copy link
Contributor

FriederikeHanssen commented Jan 27, 2021

FYI: I think the BioContainers for bwa-mem2 have been updated. It is not shown yet on the website but they are listed on https://quay.io/repository/biocontainers/bwa-mem2?tab=tags and https://depot.galaxyproject.org/singularity/ . Mulled container is still missing though as far as I see: https://quay.io/repository/biocontainers/mulled-v2-fe8faa35dbf6dc65a0f7f5d4ea12e31a79f73e40?tab=tags

There is anew bwa-mem2 container now:

 conda (params.enable_conda ? "bioconda::bwa-mem2=2.1--he513fc3_0 bioconda::samtools=1.11--h6270b1f_0" : null)
    if (workflow.containerEngine == 'singularity' && !params.pull_docker_container) {
        container "https://depot.galaxyproject.org/singularity/mulled-v2-e5d375990341c5aef3c9aff74f96f66f65375ef6:e6f0d20c9d78572ddbbf00d8767ee6ff865edd4e-0" 
    } else {
        container "quay.io/biocontainers/mulled-v2-e5d375990341c5aef3c9aff74f96f66f65375ef6:e6f0d20c9d78572ddbbf00d8767ee6ff865edd4e-0"
    }

@maxulysse maxulysse merged commit 2a15600 into nf-core:dsl2 Jan 27, 2021
@maxulysse maxulysse deleted the dsl2_somatic branch January 27, 2021 18:15
@maxulysse
Copy link
Member Author

FYI: I think the BioContainers for bwa-mem2 have been updated. It is not shown yet on the website but they are listed on https://quay.io/repository/biocontainers/bwa-mem2?tab=tags and https://depot.galaxyproject.org/singularity/ . Mulled container is still missing though as far as I see: https://quay.io/repository/biocontainers/mulled-v2-fe8faa35dbf6dc65a0f7f5d4ea12e31a79f73e40?tab=tags

There is anew bwa-mem2 container now:

 conda (params.enable_conda ? "bioconda::bwa-mem2=2.1--he513fc3_0 bioconda::samtools=1.11--h6270b1f_0" : null)
    if (workflow.containerEngine == 'singularity' && !params.pull_docker_container) {
        container "https://depot.galaxyproject.org/singularity/mulled-v2-e5d375990341c5aef3c9aff74f96f66f65375ef6:e6f0d20c9d78572ddbbf00d8767ee6ff865edd4e-0" 
    } else {
        container "quay.io/biocontainers/mulled-v2-e5d375990341c5aef3c9aff74f96f66f65375ef6:e6f0d20c9d78572ddbbf00d8767ee6ff865edd4e-0"
    }

I noticed that samtools is on version 1.11 now, I'll try and update the bwa mem container with the samtools 1.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants