Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding nf-core lint #31

Merged
merged 5 commits into from
Sep 4, 2019
Merged

adding nf-core lint #31

merged 5 commits into from
Sep 4, 2019

Conversation

maxulysse
Copy link
Member

  • Remove extra CI from Travis CI and GitHub Actions nf-core CI to new GitHub Actions nf-core extra CI
  • update code according to nf-core lint:
    • badges
    • rcolorbrewer version
    • remove TODO nf-core comments)

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/sarek/tree/master/.github/CONTRIBUTING.md

@maxulysse
Fix nf-core lint on sarek
2560f88 
* Remove extra CI from .travis.yml and GitHub Actions nf-core CI
* Add new nf-core extra CI
* Fix badges according to nf-core lint
* Remove TODO nf-core comments in code
* Use 1.1_2 version for rcolorbrewer, according to nf-core lint
@maxulysse
update
1cf17f2
@maxulysse
update CHANGELOG
fab1981
@maxulysse maxulysse requested review from alneberg and a team September 4, 2019 12:37
@maxulysse maxulysse merged commit 70fb026 into nf-core:dev Sep 4, 2019
@maxulysse maxulysse deleted the lint branch September 4, 2019 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeltzer apeltzer apeltzer approved these changes

@alneberg alneberg Awaiting requested review from alneberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @apeltzer