Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace some params #324

Merged
merged 2 commits into from
Jan 19, 2021
Merged

Replace some params #324

merged 2 commits into from
Jan 19, 2021

Conversation

maxulysse
Copy link
Member

Replace --no_gatk_spark by --use_gatk_spark and --no_gvcf by --generate_gvcf

nf-core/sarek pull request

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@maxulysse maxulysse requested a review from a team January 19, 2021 14:59
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😄

@FriederikeHanssen
Copy link
Contributor

ah forgot one thing: should it be added to the usage.md?

@maxulysse
Copy link
Member Author

ah forgot one thing: should it be added to the usage.md?

Good catch, most of the docs is now out of usage.md but we still have the description of the test profiles

@maxulysse maxulysse merged commit 1776e74 into nf-core:dev Jan 19, 2021
@maxulysse maxulysse deleted the update_params branch January 19, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants