-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tumor-only mode for Mutect2 and MSIsensor #354
Conversation
Merge from base
main.nf
Outdated
@@ -564,7 +564,7 @@ process get_software_versions { | |||
freebayes --version &> v_freebayes.txt 2>&1 || true | |||
freec &> v_controlfreec.txt 2>&1 || true | |||
gatk ApplyBQSR --help &> v_gatk.txt 2>&1 || true | |||
msisensor &> v_msisensor.txt 2>&1 || true | |||
msisensor-pro &> v_msisensor.txt 2>&1 || true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's keep msisensor
here, msisensor-pro
is not in the main container, but just used for the msi processes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot about this one ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought you wanted to keep msisensor
there instead of msisensor-pro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got spot, I forgot again about that...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really like what you did there.
Currently the tumor samples are processed with Strelka (if included in --tools) which is not really designed
to process tumor samples. Changes have been made so to process tumor samples with
Mutect2 in tumor-only mode. The same has been done to MSIsensor to be able to compute
MSI scores for tumor samples in tumor-only mode (this required an upgrade to msisensor-pro).
Notes:
correct behaviour would be to process only the tumor-only samples with Mutect2 and the germline (normal)
samples with Strelka (if there are any of course and if these tools are included in the --tools option).
the next release (dsl2).
PR checklist
scrape_software_versions.py
nf-core lint .
).nextflow run . -profile test,docker
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).