Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nf-core modules update --all #420

Merged
merged 3 commits into from
Aug 4, 2021
Merged

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@FriederikeHanssen
Copy link
Contributor

Hm, prematurely approved 😆 somethiing off with the target bed:

=================================== FAILURES ===================================
_________________________________ test session _________________________________
'Run default pipeline with target bed' exited with exit code '1' instead of '0'.
=========================== short test summary info ============================
FAILED tests/test_targeted.yml::Run default pipeline with target bed::exit code should be 0
=================== 1 failed, 21 passed in 292.13s (0:04:52) ===================
Error: Process completed with exit code 1.

@FriederikeHanssen
Copy link
Contributor

Maybe the tabix module?

@maxulysse
Copy link
Member Author

Maybe the tabix module?

I'll investigate

@FriederikeHanssen
Copy link
Contributor

The last test fails tests/test_targeted.yml .....................F are they checked by order in the yaml? Then it should be the - path: results/reports/samtools_stats/1234N/1234N.recal.cram.stats file 🤔 . But that module is not updated 😕

@maxulysse
Copy link
Member Author

I reverted the tabix modules update, and it works.
I'm assuming there's some changes there that impact the rest of the downstream analysis.

@maxulysse
Copy link
Member Author

I fixed some issues with the names of the files for the tabix modules.
I'll figure the tabix modules update in a separate PR.

@maxulysse maxulysse merged commit 8e133a5 into nf-core:dev Aug 4, 2021
@maxulysse maxulysse deleted the dev_modules_update branch August 4, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants