-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Variant Calling #497
Conversation
…cesses to terminal. Sorry @maxulysse :( we'll keep improving this
…ame, subworkflow will take priority over included module
…ps have different id fields when intervals are present
@maxulysse almost happy with the state of this, just need to add haplotypecaller and mutect back in. I think i am going for smaller PRs now, makes both of our lifes a lot easier I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3
ok, Haplotypecaller will be fixed in the next PR, after the discussion on slack it will be a little bit more then just refactoring. But it seems straight forward in the next one now. For Deepvariant: The gvcf are generated no matter what, I don't see why we shouldn't publish them, so i removed it for now. I don't know whats going on with all the CI tst, locally it's fine:
Edit: Set ressource requests to high in test.config to speed up local computation 🤦♀️ |
did you empty your results folder before doing the tests? |
See edit: increased resources locally to speed up tests and accidentally pushed them. They ran now after reducing them again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3
PR checklist
scrape_software_versions.py
nf-core lint .
).nextflow run . -profile test,docker
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).