Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cnv for real now #513

Merged
merged 47 commits into from
Apr 14, 2022
Merged

Cnv for real now #513

merged 47 commits into from
Apr 14, 2022

Conversation

FriederikeHanssen
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@FriederikeHanssen
Add in controlfreec sw
c894353
@FriederikeHanssen
nf-core update mpileup
3358c23
@FriederikeHanssen
first controlfreec version
98c0ddc
@FriederikeHanssen
install controlfreec again with significance script
2f51ecc
@FriederikeHanssen
add controlfreec plotting modules
5f070bf
@FriederikeHanssen
Install freec2circos
44a1a37
@FriederikeHanssen
Work on pari contronlfreec implementation to get tests to pass
c0473a9
@FriederikeHanssen
First running version of ControlFreec
ffe76cd
@FriederikeHanssen
nf-core modules update freec to fix typo
245c1d9
@FriederikeHanssen
fix manta-strelka combination output channel name
be78070
@FriederikeHanssen
add nextflow config with test args for freec
241ef86
@FriederikeHanssen
Fix StrelkaBP input mapping
577cff8
@FriederikeHanssen
Add StrelkaBP tests
a36a986
@FriederikeHanssen
Add controlfreec paired conf
20667a7
@FriederikeHanssen
Copy controlfreec map :crying:
0a33326
@FriederikeHanssen
same quotes, same spaces
afda89c
@FriederikeHanssen
Add tumor only controlfreec (can't test, as test data won't pass)
a7ce499
@FriederikeHanssen
Make controlfreec workflow agnostic to paired or single input
6ab729e
@FriederikeHanssen
add required cf input to tumor vc workflow
47e0497
@FriederikeHanssen
Adapt fodler structure to use controlfreec subworkflow
163c154
@FriederikeHanssen
nf-core modules update -all
6390a5d
@FriederikeHanssen
nf-core modules update -all
fa6de98
@FriederikeHanssen
prettier
817d718
@FriederikeHanssen
tests pass
50b1dda
@FriederikeHanssen FriederikeHanssen marked this pull request as ready for review April 14, 2022 06:58
@FriederikeHanssen
Copy link
Contributor Author

Just fixing the CF test now.

maxulysse
maxulysse reviewed Apr 14, 2022
View reviewed changes
conf/modules.config Outdated Show resolved Hide resolved
maxulysse
maxulysse reviewed Apr 14, 2022
View reviewed changes
conf/modules.config Outdated Show resolved Hide resolved
maxulysse
maxulysse reviewed Apr 14, 2022
View reviewed changes
nextflow.config Outdated Show resolved Hide resolved
FriederikeHanssen and others added 2 commits April 14, 2022 10:02
@FriederikeHanssen
Fix output paths
3351d2a
@FriederikeHanssen @maxulysse
Update conf/modules.config
97b0999 
Co-authored-by: Maxime U. Garcia <maxime.garcia@scilifelab.se>
maxulysse
maxulysse approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it <3

maxulysse
maxulysse reviewed Apr 14, 2022
View reviewed changes
nextflow_schema.json Outdated Show resolved Hide resolved
@FriederikeHanssen
Copy link
Contributor Author

Still trying to track down the problems Nick had with strelka

@FriederikeHanssen
Copy link
Contributor Author

nf-core lint fails on ascat module lcoally, I started adapting it for the upstream fix so i would like to leave it as is

@FriederikeHanssen FriederikeHanssen merged commit 5000c94 into nf-core:dev Apr 14, 2022
@FriederikeHanssen FriederikeHanssen deleted the cnv_for_real_now branch July 10, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FriederikeHanssen @maxulysse