Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

params.sequencing_center -> params.seq_center + add params.seq_platform #538

Merged
merged 5 commits into from
May 4, 2022
Merged

params.sequencing_center -> params.seq_center + add params.seq_platform #538

merged 5 commits into from
May 4, 2022

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

maxulysse and others added 2 commits May 4, 2022 13:38
@maxulysse
typo
c548b4b
@maxulysse @FriederikeHanssen
Apply suggestions from code review
6431877 
Co-authored-by: FriederikeHanssen <Friederike.hanssen@qbic.uni-tuebingen.de>
maxulysse
maxulysse commented May 4, 2022
View reviewed changes
nextflow_schema.json Outdated Show resolved Hide resolved
@maxulysse maxulysse merged commit 3bcf3bb into nf-core:dev May 4, 2022
@maxulysse maxulysse deleted the dev_seq_platform_center branch July 7, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @FriederikeHanssen