Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging template updates 2.4 #551

Merged

Conversation

FriederikeHanssen
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@maxulysse
Copy link
Member

How come nf-core lint is failing?

@FriederikeHanssen
Copy link
Contributor Author

Modules updates

 ╭─ [✗] 1 Module Test Failed ───────────────────────────────────────────────────╮
│                                           ╷                ╷                 │
│ Module name                               │ File path      │ Test message    │
│╶──────────────────────────────────────────┼────────────────┼────────────────╴│
│ ascat                                     │ modules/nf-co… │ Local copy of   │
│                                           │                │ module does not │
│                                           │                │ match remote    │
│                                           ╵                ╵                 │
╰──────────────────────────────────────────────────────────────────────────────╯

I messed around with the module at osme point. But @SusiJo is working on the CNV stuff now, so I don't want to touch it and create merge conflicts for her

@FriederikeHanssen
Copy link
Contributor Author

Good thing though that linting fails with informative errors again, so The GH fix is working

@FriederikeHanssen FriederikeHanssen merged commit 516af88 into nf-core:dev May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants