Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted svg for firefox compatibility #572

Merged
merged 2 commits into from
Jun 1, 2022

Conversation

SusiJo
Copy link
Contributor

@SusiJo SusiJo commented Jun 1, 2022

PR checklist

This PR fixes the SVG issue of the subway map, in which weird lines were displayed in Firefox. SVGs that are produced with Adobe Illustrator add masks to the paths that cannot be processed by Firefox, therefore Inkscape is actually the better choice for SVG development across browsers.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thank you. What was the trick?

@SusiJo
Copy link
Contributor Author

SusiJo commented Jun 1, 2022

Switching to Inkscape and changing everything again :D
The fonts in your previous version were not displayed because the objects were not actually text and needed to be converted to text

@FriederikeHanssen FriederikeHanssen merged commit 99b61d9 into nf-core:dev Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants