Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Test Data #580

Merged
merged 9 commits into from
Jun 21, 2022
Merged

Full Test Data #580

merged 9 commits into from
Jun 21, 2022

Conversation

nickhsmith
Copy link
Contributor

update the test_full samplesheet to be full open source WXS data from GIAB and NCBI

conf/test_full.config Outdated Show resolved Hide resolved
conf/test_full.config Outdated Show resolved Hide resolved
nickhsmith and others added 3 commits June 8, 2022 12:38
Co-authored-by: Maxime U. Garcia <maxime.garcia@scilifelab.se>
Co-authored-by: Maxime U. Garcia <maxime.garcia@scilifelab.se>
Co-authored-by: Maxime U. Garcia <maxime.garcia@scilifelab.se>
@nickhsmith
Copy link
Contributor Author

I will say that these are real life examplse of WXS, but we could down-sample or find sequencing runs with less coverage if the storage/compute time is too large.

@maxulysse
Copy link
Member

If you can just update the CHANGELOG that would be perfect.
I'd say we need to run it once to figure out if we need to down-sample

@FriederikeHanssen
Copy link
Contributor

@nickhsmith from what publication is the paired data coming from?

CHANGELOG.md Outdated Show resolved Hide resolved
@nickhsmith
Copy link
Contributor Author

@nickhsmith from what publication is the paired data coming from?

Good point. I'll add that to the log

CHANGELOG.md Outdated Show resolved Hide resolved
@FriederikeHanssen
Copy link
Contributor

Wondering if this large file staging will work. Might have to upload htem to the bucket directly and then change the paths

Co-authored-by: Maxime U. Garcia <maxime.garcia@scilifelab.se>
@nickhsmith
Copy link
Contributor Author

Wondering if this large file staging will work. Might have to upload them to the bucket directly and then change the paths

We can move them to whichever bucket we'd like
https://www.ncbi.nlm.nih.gov/Traces/cloud-delivery/

@maxulysse
Copy link
Member

@nf-core-bot fix linting

@@ -0,0 +1,4 @@
patient,status,sample,lane,fastq_1,fastq_2
HG002,0,HG002,1,s3://giab/data/AshkenazimTrio/HG002_NA24385_son/NIST_Illumina_2x250bps/reads/D1_S1_L001_R1_001.fastq.gz,s3://giab/data/AshkenazimTrio/HG002_NA24385_son/NIST_Illumina_2x250bps/reads/D1_S1_L001_R2_001.fastq.gz
HCC1395,0,HCC1395-Normal,1,https://ftp.sra.ebi.ac.uk/vol1/fastq/SRR789/001/SRR7890851/SRR7890851_1.fastq.gz,https://ftp.sra.ebi.ac.uk/vol1/fastq/SRR789/001/SRR7890851/SRR7890851_2.fastq.gz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend to upload those directly into our S3 bucket to avoid issues that occur when the file download on S3 times out

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that if you like, let me know @FriederikeHanssen

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we just test it out with the first sample so far?

@@ -0,0 +1,4 @@
patient,status,sample,lane,fastq_1,fastq_2
HG002,0,HG002,1,s3://giab/data/AshkenazimTrio/HG002_NA24385_son/NIST_Illumina_2x250bps/reads/D1_S1_L001_R1_001.fastq.gz,s3://giab/data/AshkenazimTrio/HG002_NA24385_son/NIST_Illumina_2x250bps/reads/D1_S1_L001_R2_001.fastq.gz
HCC1395,0,HCC1395-Normal,1,https://ftp.sra.ebi.ac.uk/vol1/fastq/SRR789/001/SRR7890851/SRR7890851_1.fastq.gz,https://ftp.sra.ebi.ac.uk/vol1/fastq/SRR789/001/SRR7890851/SRR7890851_2.fastq.gz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we just test it out with the first sample so far?

tests/csv/3.0/test_full_data.csv Outdated Show resolved Hide resolved
tests/csv/3.0/test_full_data.csv Outdated Show resolved Hide resolved
@ggabernet ggabernet merged commit 0c78408 into nf-core:dev Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants