Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate ascat and controlfreec ploidy #663

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

FriederikeHanssen
Copy link
Contributor

ASCAT ploidy and ControlFREEC ploidy parameters are both specified completely differently. If only one parameter caters to both tools, you could not run both tools in parallel very well.

@github-actions
Copy link

github-actions bot commented Jul 19, 2022

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit c5ab1a1

+| ✅ 146 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version badge.

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-07-19 20:59:54

@SusiJo
Copy link
Contributor

SusiJo commented Jul 20, 2022

Thanks for changing the ploidy, makes sense to separate them 👍

@maxulysse maxulysse merged commit e5a4ffb into nf-core:dev Jul 20, 2022
@FriederikeHanssen FriederikeHanssen deleted the ascat_controlfreec_ploidy branch July 10, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants