Important! Template update for nf-core/tools v2.5 #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxulysse
reviewed
Aug 30, 2022
Comment on lines
34
to
35
| - name: Run pipeline with test data | ||
| # TODO nf-core: You can customise CI pipeline run tests as required |
There was a problem hiding this comment.
I think there's an issue here
maxulysse
reviewed
Aug 30, 2022
Comment on lines
+16
to
+17
| - family-names: Ulysse Garcia | ||
| given-names: Maxime |
There was a problem hiding this comment.
ok, that's not my family name...
I should have catch that in tools...
maxulysse
reviewed
Aug 30, 2022
| @@ -11,7 +11,6 @@ | |||
| from collections import Counter | |||
| from pathlib import Path | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
I though we deleted this file already
maxulysse
reviewed
Aug 30, 2022
| @@ -4,7 +4,7 @@ | |||
| nf-core/sarek | |||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
| Github : https://github.com/nf-core/sarek | |||
| Website: https://nf-co.re/sarek | |||
| Website: https://nf-co.re/sarek | |||
maxulysse
reviewed
Aug 30, 2022
Comment on lines
+6
to
+19
| "git_url": "https://github.com/nf-core/modules.git", | ||
| "modules": { | ||
| "custom/dumpsoftwareversions": { | ||
| "git_sha": "e745e167c1020928ef20ea1397b6b4d230681b4d", | ||
| "branch": "master" | ||
| }, | ||
| "fastqc": { | ||
| "git_sha": "e745e167c1020928ef20ea1397b6b4d230681b4d", | ||
| "branch": "master" | ||
| }, | ||
| "multiqc": { | ||
| "git_sha": "e745e167c1020928ef20ea1397b6b4d230681b4d", | ||
| "branch": "master" | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version
2.5of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the
nf-core-template-merge-2.5branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.For instructions on how to merge this PR, please see https://nf-co.re/developers/sync.
For more information about this release of nf-core/tools, please see the
v2.5release page.