Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all the modules #734

Merged
merged 27 commits into from
Sep 8, 2022
Merged

Update all the modules #734

merged 27 commits into from
Sep 8, 2022

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@maxulysse maxulysse marked this pull request as draft September 7, 2022 10:07
@github-actions
Copy link

github-actions bot commented Sep 7, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 805cc1d

+| ✅ 151 tests passed       |+
#| ❔   4 tests were ignored |#

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.5.1
  • Run at 2022-09-07 16:21:54

@FriederikeHanssen
Copy link
Contributor

samtools also had a new release.. should we bump?

@FriederikeHanssen
Copy link
Contributor

the md cram update, I can do in a separate PR, because it needs some adaption to the subworkflows

@maxulysse
Copy link
Member Author

samtools also had a new release.. should we bump?

Good idea

the md cram update, I can do in a separate PR, because it needs some adaption to the subworkflows

Forgot about it, that's a good idea indeed, let me revert that one

@FriederikeHanssen FriederikeHanssen mentioned this pull request Sep 7, 2022
Closed
@maxulysse maxulysse marked this pull request as ready for review September 7, 2022 15:14
FriederikeHanssen
FriederikeHanssen approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@maxulysse maxulysse merged commit f7c4caf into nf-core:dev Sep 8, 2022
@maxulysse maxulysse deleted the dev_modules_update branch September 8, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @FriederikeHanssen