Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused scripts and improve CI #74

Merged
merged 6 commits into from
Dec 9, 2019
Merged

Remove unused scripts and improve CI #74

merged 6 commits into from
Dec 9, 2019

Conversation

maxulysse
Copy link
Member

  • Improve CI
  • Remove unused scripts (run_tests.sh and download_image.sh)
  • Update docs

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: guidelines

@maxulysse maxulysse self-assigned this Dec 9, 2019
@maxulysse maxulysse added docs enhancement New feature or request labels Dec 9, 2019
@maxulysse maxulysse requested a review from a team December 9, 2019 14:42
apeltzer
apeltzer approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean up looks good 🎉

@maxulysse maxulysse merged commit 0612068 into nf-core:dev Dec 9, 2019
@maxulysse maxulysse deleted the CLEANUP branch December 9, 2019 14:48
This was referenced Dec 23, 2019
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeltzer apeltzer apeltzer approved these changes

Assignees

@maxulysse maxulysse

Labels
docs enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @apeltzer