Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to new modules syntax + patch on non-up to date modules #771

Merged
merged 2 commits into from
Oct 5, 2022
Merged

update to new modules syntax + patch on non-up to date modules #771

merged 2 commits into from
Oct 5, 2022

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@maxulysse maxulysse changed the title update to new modules syntax + diff on non-up to date modules update to new modules syntax + patch on non-up to date modules Oct 4, 2022
@maxulysse maxulysse mentioned this pull request Oct 5, 2022
Merged
9 tasks
asp8200
asp8200 approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@asp8200 asp8200 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked your previous PR better 😁

@maxulysse maxulysse merged commit 0e38fea into nf-core:dev Oct 5, 2022
@maxulysse maxulysse deleted the dev_tools_dev_refactor branch October 5, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asp8200 asp8200 asp8200 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @asp8200