Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nf-core modules update -a #874

Merged
merged 11 commits into from
Dec 1, 2022
Merged

nf-core modules update -a #874

merged 11 commits into from
Dec 1, 2022

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Nov 30, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit d88e67c

+| ✅ 151 tests passed       |+
#| ❔   8 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline
  • schema_description - No description provided in schema for parameter: cnvkit_reference

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.6
  • Run at 2022-12-01 10:00:44

@FriederikeHanssen FriederikeHanssen self-requested a review December 1, 2022 09:44
FriederikeHanssen
FriederikeHanssen reviewed Dec 1, 2022
View reviewed changes
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You split up the test_extended.yml over multiple files?

Table with updated versions to Changelog?

@maxulysse
Copy link
Member Author

You split up the test_extended.yml over multiple files?

Yes, otherwise it takes 45 min and + to completion

Table with updated versions to Changelog?

I'll check it up rn

@maxulysse
Copy link
Member Author

we're done, prettier was done locally, I skipped the CI, because I didn't want to rerun all tests just for a change in CHANGELOG

@maxulysse maxulysse merged commit fe24ecb into nf-core:dev Dec 1, 2022
@maxulysse maxulysse deleted the dev_update_modules branch December 1, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @FriederikeHanssen