Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging template updates 2.7.1 #890

Merged
merged 5 commits into from
Dec 11, 2022
Merged

Merging template updates 2.7.1 #890

merged 5 commits into from
Dec 11, 2022

Conversation

FriederikeHanssen
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen commented Dec 9, 2022 •
edited
Loading

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@FriederikeHanssen
Copy link
Contributor Author

@nf-core-bot fix linting please

@github-actions
Copy link

github-actions bot commented Dec 9, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 2512416

+| ✅ 150 tests passed       |+
#| ❔   8 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline
  • schema_description - No description provided in schema for parameter: cnvkit_reference

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.1
  • Run at 2022-12-09 15:31:05

@FriederikeHanssen
Copy link
Contributor Author

@nf-core-bot fix linting

FriederikeHanssen
FriederikeHanssen commented Dec 9, 2022
View reviewed changes
nextflow.config Outdated Show resolved Hide resolved
maxulysse
maxulysse reviewed Dec 9, 2022
View reviewed changes
docs/usage.md Outdated Show resolved Hide resolved
maxulysse
maxulysse requested changes Dec 9, 2022
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rnaseq -> sarek

@FriederikeHanssen @maxulysse
Update docs/usage.md
2512416 
Co-authored-by: Maxime U. Garcia <maxime.garcia@scilifelab.se>
@maxulysse maxulysse merged commit 7cb2245 into nf-core:dev Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FriederikeHanssen @maxulysse @nf-core-bot