Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote test warning from nf-core lint #894

Merged
merged 5 commits into from
Dec 12, 2022
Merged

Remote test warning from nf-core lint #894

merged 5 commits into from
Dec 12, 2022

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Dec 12, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 4ac0b43

+| ✅ 151 tests passed       |+
#| ❔   8 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.1
  • Run at 2022-12-12 16:14:27

JoseEspinosa
JoseEspinosa approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small question 🚀

modules.json Show resolved Hide resolved
@maxulysse maxulysse merged commit e48ce04 into nf-core:dev Dec 12, 2022
FriederikeHanssen
FriederikeHanssen reviewed Dec 13, 2022
View reviewed changes
assets/methods_description_template.yml
@@ -3,8 +3,6 @@ description: "Suggested text and references to use when describing pipeline usag
section_name: "nf-core/sarek Methods Description"
section_href: "https://github.com/nf-core/sarek"
plot_type: "html"
## TODO nf-core: Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we add some description on sarek here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the other pipelines, and nothing is there, the only difference I saw in some pipelines was the comments removed.
I'm not sure why it's in the TEMPLATE

@maxulysse maxulysse deleted the remove_test_warnings branch December 16, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen left review comments

@JoseEspinosa JoseEspinosa JoseEspinosa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxulysse @JoseEspinosa @FriederikeHanssen