Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing annotation keys for vep/snpeff #954

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Fix missing annotation keys for vep/snpeff #954

merged 1 commit into from
Mar 2, 2023

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Feb 24, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit cd86dcc

+| ✅ 152 tests passed       |+
#| ❔   8 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-02-24 09:29:01

FriederikeHanssen
FriederikeHanssen approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry didn't see this earlier. Quick question are the chromosome prefixes working, i.e. 1 vs chr1?

@maxulysse
Copy link
Member Author

No idea, hoping to see that when we manage to fix #953

@maxulysse maxulysse mentioned this pull request Mar 2, 2023
Closed
@maxulysse maxulysse merged commit 4e60e8c into nf-core:dev Mar 2, 2023
@maxulysse maxulysse deleted the annotation_hg19 branch March 2, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @FriederikeHanssen